Skip to content

Fix many skills not enabling the Wither config option#1809

Merged
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
krryan:wither-flags
May 26, 2026
Merged

Fix many skills not enabling the Wither config option#1809
LocalIdentity merged 2 commits into
PathOfBuildingCommunity:devfrom
krryan:wither-flags

Conversation

@krryan

@krryan krryan commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

The “# of Wither Stacks” config was not enabled by Chaos Bolt, His Foul Emergence, Withering Presence, Withering Touch, Wither Away, or The Right Hand of Darkness.

Steps taken to verify a working solution:

  • Added each skill listed above one by one (without the others), to ensure the “# of Wither Stacks” config appeared as expected in each case.

Link to a build that showcases this PR:

https://pobb.in/RRWhH42PJV3X
(Not that there’s much point, just add any of the skills or take any of the nodes listed here.)

Before screenshot:

image

After screenshot:

image

@krryan

krryan commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

I attempted to add unit tests for this, but couldn’t figure out how to test that the config was shown. I was using

	it("Test Wither stack config with Chaos Bolt", function()
		build.skillsTab:PasteSocketGroup("Chaos Bolt 1/0  1\n")

		assert.is_true(build.configTab.varControls.multiplierWitheredStackCount.shown())
	end)

but I think I need to run something in between these two to get the .shown() to update. I tried configTab:BuildModList() and configTab:UpdateControls(), but those did not work. I realize there aren’t a ton of unit tests here, and this is a pretty simple thing that maybe doesn’t need them, but thought the commentary might be useful for maintainers as something to think about if you’d like to see more unit tests.

@LocalIdentity LocalIdentity changed the title Adds 'Condition:CanWither' flag to numerous skills and supports Fix many skills not enabling the Wither config option May 26, 2026
@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label May 26, 2026
@LocalIdentity LocalIdentity merged commit db8c024 into PathOfBuildingCommunity:dev May 26, 2026
2 of 3 checks passed
bct8925 pushed a commit to bct8925/PathOfBuilding-PoE2 that referenced this pull request Jun 19, 2026
@krryan @DragoonWraith
Fix many skills not enabling the Wither config option (PathOfBuilding…
602c465 
…Community#1809)

* Adds 'Condition:CanWither' flag to numerous skills and supports

* Move to global stat map + support wither spell

---------

Co-authored-by: DragoonWraith (github: krryan) <dragoonwraith@gmail.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees

No one assigned

Labels

bug: behaviour Behavioral differences

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krryan @LocalIdentity @DragoonWraith